Fossil

Timeline
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

9 events for 2018-11 by user florian

2018-11-24
07:49
Minor optimizations: drop a few redundant comparisons and calculations, and take advantage of the logical AND short-circuit by testing the least expensive and most unlikely condition first. Also fold away the iterative comments into cross references. check-in: 490d38ff2e user: florian tags: comment-formatter-utf8
07:16
Fix two bugs (introduced with this branch) that become manifest with invalid UTF-8 sequences. check-in: b86a2fc7eb user: florian tags: comment-formatter-utf8
2018-11-16
19:39
Fix a bug (already present on trunk) with the (non-legacy) comment printing algorithm, detected while running the regression tests from test/comment.test with UTF-8 text: the function to print the indent (modified to a calculate-only function on this branch) was handed a pointer to the current line index and the current line index, thus performing checks at (current line index * 2), causing random increments of the current line index. check-in: 70dd8f744f user: florian tags: comment-formatter-utf8
14:02
More coding style fixes. check-in: 2dca9b82d9 user: florian tags: comment-formatter-utf8
11:26
Coding style fixes. check-in: aadbbb38d6 user: florian tags: comment-formatter-utf8
11:14
For better word breaking results with the (non-legacy) comment printing algorithm, make sure the lookahead to the next space character is UTF-8-aware. Also make sure the per-line remaining character count is decremented properly for UTF-8 sequences. The neuralgic points now handle UTF-8 sequences correctly, and they could be enhanced to work with the effective display width, if required (to handle combining characters, and East Asian Wide and Fullwidth characters). check-in: c9ec3d1886 user: florian tags: comment-formatter-utf8
2018-11-15
15:32
Ensure the line buffer for the legacy comment printing algorithm can hold maximum-length UTF-8 sequences. check-in: 29d3a2ed4e user: florian tags: comment-formatter-utf8
15:16
Fix a problem with initial indent introduced by the previous check-in, so that all regression tests from test/comment.test now succeed. Also eliminate three more calls to fossil_print(). Regarding performance, the legacy comment printing algorithm is outnumbered by factor 2-3, with these changes. check-in: b029ed2222 user: florian tags: comment-formatter-utf8
12:43
Add output buffering to the (non-legacy) comment printing algorithm, to reduce calls to fossil_print(). The resulting performance improvement can be up to factor 10, with a perceptible difference even for short comments (measured and tested on Windows with MSVC builds, and on Ubuntu with GCC builds). (For comparison: for the legacy comment printing algorithm, the extra UTF-8 checks added by this branch impair performance by 0.12-1.8%, depending on whether the input contains predominantly multi-byte vs. ASCII-only sequences.) check-in: 16fde3ff66 user: florian tags: comment-formatter-utf8